[Differential] [Updated] D1931: Avoid asking model to create string-serialized icon data where possible.

[hein (Eike Hein)]

hein marked an inline comment as done.
hein added a comment.


  I didn't like "WithIcon" because it sounds like it guarantees handing over an icon, but it's really a fallback - so would have to be LauncherUrlWithFallbackIcon, which is quite a mouthful. I think it's prettier to have LauncherUrl to be the full thing and opt into the restrictions :)

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D1931

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, dfaure
Cc: plasma-devel, jensreuterberg, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160617/a0f1f8f9/attachment.html>