Review Request 128203: Avoid lots of useless po/*/messages.mo files in released tarballs

Friedrich W. H. Kossebau kossebau at kde.org
Thu Jun 16 08:13:29 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128203/
-----------------------------------------------------------

(Updated June 16, 2016, 8:13 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma, Albert Astals Cid, Jonathan Riddell, Luigi Toscano, and Harald Sitter.


Changes
-------

Submitted with commit 40e9146fba8fdfa1ca11abb34f371f5ce1ae7d05 by Friedrich W. H. Kossebau to branch master.


Repository: releaseme


Description
-------

Currently all projects which use releaseme for creating the source tarballs have in all the po/*/ dirs a file messages.mo. Seems this file is an artifact when running `LC_ALL=C LANG=C msgfmt --statistics #{file} > /dev/stdout 2>&1` to get statistics about the number of translated strings per language. Only problem is that this also results in msgfmt creating the output file named `messages.po` per default in the very sources, once per language.

Just piping the output to /dev/null seemed simplest to me, no idea if this works on all platforms releaseme targets. Could also be solved by simply cleaning up and removing the created file afterwards, if that will work in more places.


Diffs
-----

  lib/l10nstatistics.rb d76f531 

Diff: https://git.reviewboard.kde.org/r/128203/diff/


Testing
-------

Only tested `LC_ALL=C LANG=C msgfmt --statistics somefile.po -o /dev/null> 2>&1` on the commandline, worked as expected, no file created.


Thanks,

Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160616/896658c4/attachment.html>


More information about the Plasma-devel mailing list