Review Request 128203: Avoid lots of useless po/*/messages.mo files in released tarballs

[Harald Sitter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128203/#review96559
-----------------------------------------------------------


Ship it!




Ship It!

- Harald Sitter


On June 16, 2016, 12:25 a.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128203/
> -----------------------------------------------------------
> 
> (Updated June 16, 2016, 12:25 a.m.)
> 
> 
> Review request for Plasma, Albert Astals Cid, Jonathan Riddell, Luigi Toscano, and Harald Sitter.
> 
> 
> Repository: releaseme
> 
> 
> Description
> -------
> 
> Currently all projects which use releaseme for creating the source tarballs have in all the po/*/ dirs a file messages.mo. Seems this file is an artifact when running `LC_ALL=C LANG=C msgfmt --statistics #{file} > /dev/stdout 2>&1` to get statistics about the number of translated strings per language. Only problem is that this also results in msgfmt creating the output file named `messages.po` per default in the very sources, once per language.
> 
> Just piping the output to /dev/null seemed simplest to me, no idea if this works on all platforms releaseme targets. Could also be solved by simply cleaning up and removing the created file afterwards, if that will work in more places.
> 
> 
> Diffs
> -----
> 
>   lib/l10nstatistics.rb d76f531 
> 
> Diff: https://git.reviewboard.kde.org/r/128203/diff/
> 
> 
> Testing
> -------
> 
> Only tested `LC_ALL=C LANG=C msgfmt --statistics somefile.po -o /dev/null> 2>&1` on the commandline, worked as expected, no file created.
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160616/ecb7fa13/attachment.html>