[Differential] [Accepted] D1791: Give a screen to systray applets

davidedmundson (David Edmundson) noreply at phabricator.kde.org
Tue Jun 7 14:20:12 UTC 2016


davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  much neater ++

INLINE COMMENTS

> shellcorona.cpp:345
>          foreach(Plasma::Containment *containment, containments()) {
> -            if (containment->formFactor() == Plasma::Types::Horizontal ||
> -                containment->formFactor() == Plasma::Types::Vertical) {
> +            if (containment->containmentType() != Plasma::Types::CustomEmbeddedContainment && (containment->formFactor() == Plasma::Types::Horizontal ||
> +                containment->formFactor() == Plasma::Types::Vertical)) {

given the code beneath searches in m_panels and m_desktop white listing would match better.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1791

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, davidedmundson
Cc: davidedmundson, plasma-devel, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160607/c9e23c43/attachment.html>


More information about the Plasma-devel mailing list