<table><tr><td style="">davidedmundson accepted this revision.<br />davidedmundson added a reviewer: davidedmundson.<br />davidedmundson added a comment.<br />This revision is now accepted and ready to land.</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D1791" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>much neater ++</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D1791#inline-6999" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">shellcorona.cpp:345</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">        <span class="n">foreach</span><span class="p">(</span><span class="n">Plasma</span><span style="color: #aa2211">::</span><span class="n">Containment</span> <span style="color: #aa2211">*</span><span class="n">containment</span><span class="p">,</span> <span class="n">containments</span><span class="p">())</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">            <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">containment</span><span style="color: #aa2211">-></span><span class="n">formFactor</span><span class="p">()</span> <span style="color: #aa2211">==</span> <span class="n">Plasma</span><span style="color: #aa2211">::</span><span class="n">Types</span><span style="color: #aa2211">::</span><span class="n">Horizontal</span> <span style="color: #aa2211">||</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">                <span class="n">containment</span><span style="color: #aa2211">-></span><span class="n">formFactor</span><span class="p">()</span> <span style="color: #aa2211">==</span> <span class="n">Plasma</span><span style="color: #aa2211">::</span><span class="n">Types</span><span style="color: #aa2211">::</span><span class="n">Vertical</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">            <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">containment</span><span style="color: #aa2211">-><span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">containmentType</span></span><span class="bright"></span><span class="p"><span class="bright">()</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">!=</span></span><span class="bright"> </span><span class="n"><span class="bright">Plasma</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">Types</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">CustomEmbeddedContainment</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">&&</span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">containment</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="n">formFactor</span><span class="p">()</span> <span style="color: #aa2211">==</span> <span class="n">Plasma</span><span style="color: #aa2211">::</span><span class="n">Types</span><span style="color: #aa2211">::</span><span class="n">Horizontal</span> <span style="color: #aa2211">||</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">                <span class="n">containment</span><span style="color: #aa2211">-></span><span class="n">formFactor</span><span class="p">()</span> <span style="color: #aa2211">==</span> <span class="n">Plasma</span><span style="color: #aa2211">::</span><span class="n">Types</span><span style="color: #aa2211">::</span><span class="n">Vertical</span><span class="p">)<span class="bright">)</span></span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">given the code beneath searches in m_panels and m_desktop white listing would match better.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>rPLASMAWORKSPACE Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D1791" rel="noreferrer">https://phabricator.kde.org/D1791</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>mart, davidedmundson<br /><strong>Cc: </strong>davidedmundson, plasma-devel, sebas<br /></div>