[Differential] [Request, 21 lines] D1768: Pass screen ID to systray applets
davidedmundson (David Edmundson)
noreply at phabricator.kde.org
Sun Jun 5 09:49:19 UTC 2016
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
The Corona generally is responsible for managing which screen a
containment is on.
However ShellCorona doesn't know which screen the inner containment of
the sysem tray is on.
This patch makes the systemtray's inner container emit the
screenChanged() signal as appropriate for the container the screen is
on.
This is needed to fix a large regression seen with the notification
applet which cannot get the right screen area in a multiscreen set up.
-
I'd welcome better suggestions on how to solve this as this isn't ideal.
TEST PLAN
Moved notification applet between screens
Emitted a notification with notify-send
They were on the correct screen
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
BRANCH
notifications_screen
REVISION DETAIL
https://phabricator.kde.org/D1768
AFFECTED FILES
applets/notifications/lib/notificationsapplet.cpp
applets/notifications/lib/notificationsapplet.h
applets/systemtray/container/systemtraycontainer.cpp
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmundson, #plasma
Cc: plasma-devel, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160605/2aaca5ae/attachment-0001.html>
More information about the Plasma-devel
mailing list