Review Request 128550: [TextField] Bind to TextField length instead of text

Kai Uwe Broulik kde at privat.broulik.de
Fri Jul 29 13:42:33 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128550/
-----------------------------------------------------------

(Updated July 29, 2016, 1:42 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit 42193ae6312be533d464f49c989776a3257d3caa by Kai Uwe Broulik to branch master.


Repository: plasma-framework


Description
-------

Copying strings in QML is expensive.


Diffs
-----

  src/declarativeimports/plasmacomponents/qml/TextField.qml c027add 

Diff: https://git.reviewboard.kde.org/r/128550/diff/


Testing
-------

As per documentation "This property can be faster than querying the length of the text property as it doesn't require any copying or conversion of the TextField's internal string data."

Button still works as expected


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160729/ec061c9b/attachment.html>


More information about the Plasma-devel mailing list