Review Request 128550: [TextField] Bind to TextField length instead of text

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128550/#review97904
-----------------------------------------------------------


Ship it!




Ship It!

- David Edmundson


On July 29, 2016, 12:17 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128550/
> -----------------------------------------------------------
> 
> (Updated July 29, 2016, 12:17 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Copying strings in QML is expensive.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/plasmacomponents/qml/TextField.qml c027add 
> 
> Diff: https://git.reviewboard.kde.org/r/128550/diff/
> 
> 
> Testing
> -------
> 
> As per documentation "This property can be faster than querying the length of the text property as it doesn't require any copying or conversion of the TextField's internal string data."
> 
> Button still works as expected
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160729/3656a406/attachment.html>