[Differential] [Requested Changes To] D2264: [ksmserver/greeter] Show one logout greeter on each screen

[davidedmundson (David Edmundson)]

davidedmundson requested changes to this revision.
davidedmundson added a reviewer: davidedmundson.
davidedmundson added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> shutdowndlg.cpp:182
>  
> -    show();
> +    connect(this, &QWindow::screenChanged, this,
> +        [this] (QScreen *screen) {

What are you trying to do here?

(because I'm pretty sure this isn't going to do what you want, and you've got a possibility to infinite loop)

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2264

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160722/02f6bf1a/attachment.html>