[Differential] [Commented On] D2248: [kcm] Show output name in output preview

[graesslin (Martin Gräßlin)]

graesslin added a comment.


  generally looks ok to me.

INLINE COMMENTS

> Output.qml:254
>                      id: label
> -                    text: if (root.isCloneMode === true) {
> -                            return "";
> -                          } else if (root.output.type != KScreenOutput.Panel && root.output.edid && root.output.edid.name) {
> -                            return root.output.edid.name;
> -                          } else {
> -                            return "";
> -                          }
> +                    text: (labelVendor.text === root.output.name) ? "" : root.output.name
>  

this one looks confusing to my: why is the vendor compared to output.name? Just from reading it, one doesn't assume that root.output.name is also the vendor.

REPOSITORY
  rKSCREEN KScreen

REVISION DETAIL
  https://phabricator.kde.org/D2248

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: sebas, #plasma
Cc: graesslin, plasma-devel, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160721/e75c93ed/attachment.html>