<table><tr><td style="">graesslin added a comment.</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D2248" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>generally looks ok to me.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D2248#inline-8923" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">Output.qml:254</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">                    <span style="color: #aa4000">id: label</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">                    <span style="color: #aa4000">text:</span> <span class="bright"></span><span style="color: #aa4000"><span class="bright">if</span></span><span class="bright"> </span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">root</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">isCloneMode</span></span> <span style="color: #aa2211">===</span> <span class="bright"></span><span style="color: #000a65"><span class="bright">true</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span class="p"><span class="bright">{</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">                            <span style="color: #aa4000">return</span> <span style="color: #766510">""</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">                          <span class="p">}</span> <span style="color: #aa4000">else</span> <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #004012">root</span><span class="p">.</span><span style="color: #004012">output</span><span class="p">.</span><span style="color: #004012">type</span> <span style="color: #aa2211">!=</span> <span style="color: #004012">KScreenOutput</span><span class="p">.</span><span style="color: #004012">Panel</span> <span style="color: #aa2211">&&</span> <span style="color: #004012">root</span><span class="p">.</span><span style="color: #004012">output</span><span class="p">.</span><span style="color: #004012">edid</span> <span style="color: #aa2211">&&</span> <span style="color: #004012">root</span><span class="p">.</span><span style="color: #004012">output</span><span class="p">.</span><span style="color: #004012">edid</span><span class="p">.</span><span style="color: #004012">name</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">                            <span style="color: #aa4000">return</span> <span style="color: #004012">root</span><span class="p">.</span><span style="color: #004012">output</span><span class="p">.</span><span style="color: #004012">edid</span><span class="p">.</span><span style="color: #004012">name</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">                          <span class="p">}</span> <span style="color: #aa4000">else</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">                            <span style="color: #aa4000">return</span> <span style="color: #766510">""</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">                          <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">                    <span style="color: #aa4000">text:</span> <span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">labelVendor</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">text</span></span> <span style="color: #aa2211">===</span> <span class="bright"></span><span style="color: #004012"><span class="bright">root</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">output</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">name</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">?</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">""</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">:</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">root</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">output</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">name</span></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">this one looks confusing to my: why is the vendor compared to output.name? Just from reading it, one doesn't assume that root.output.name is also the vendor.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>rKSCREEN KScreen</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D2248" rel="noreferrer">https://phabricator.kde.org/D2248</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>sebas, Plasma<br /><strong>Cc: </strong>graesslin, plasma-devel, jensreuterberg, abetts, sebas<br /></div>