Review Request 128447: KCM move digital camera into subsection removable-device

[Andreas Kainz]

> On Juli 18, 2016, 9:45 vorm., Luigi Toscano wrote:
> > No review for this?
> > 
> > You applied this to kamera, shipped with KDE Applications, and you applied it to master only, which means KDE Applications 16.12 (next December).
> > 
> > Questions:
> > - was this intended, or should have landed into Applications 15.08? 
> > - what happens when this patch is applied and the application is installed on a system with the old Plasma? Will the applet be visible inside systemsettings? 
> > - and the other way around: what happens if the program without the patch (so with the current category) is executed inside a systemsettings with the new categories?
> > - are there other similar patches around for other programs which are in KDE Applications and not in Plasma?

I add the subgroup 2 days ago to kde:systemsettings repository. after it was there in master I'll test the subgroups for digital camera, removable devices and device actions (the last two are in kde:plasma-desktop) as plasma-desktop will ship with 5.8 in autumn I would say let it in master and the camera kcm will ship with 16.12 in the new subgroup. so it is as it is now and with 16.12 the kcm will move.


- Andreas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128447/#review97518
-----------------------------------------------------------


On Juli 17, 2016, 9:25 nachm., Andreas Kainz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128447/
> -----------------------------------------------------------
> 
> (Updated Juli 17, 2016, 9:25 nachm.)
> 
> 
> Review request for Plasma and Thomas Pfeiffer.
> 
> 
> Repository: kamera
> 
> 
> Description
> -------
> 
> with this patch https://git.reviewboard.kde.org/r/128445/ I add an subgroup removabel devices and now I move the kcm digital camera into the new subgroup.
> 
> 
> Diffs
> -----
> 
>   kcontrol/kamera.desktop 0b35db8 
> 
> Diff: https://git.reviewboard.kde.org/r/128447/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andreas Kainz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160718/6713174a/attachment.html>