<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128447/">https://git.reviewboard.kde.org/r/128447/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On Juli 18th, 2016, 9:45 vorm. UTC, <b>Luigi Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">No review for this?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">You applied this to kamera, shipped with KDE Applications, and you applied it to master only, which means KDE Applications 16.12 (next December).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Questions:
- was this intended, or should have landed into Applications 15.08?
- what happens when this patch is applied and the application is installed on a system with the old Plasma? Will the applet be visible inside systemsettings?
- and the other way around: what happens if the program without the patch (so with the current category) is executed inside a systemsettings with the new categories?
- are there other similar patches around for other programs which are in KDE Applications and not in Plasma?</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I add the subgroup 2 days ago to kde:systemsettings repository. after it was there in master I'll test the subgroups for digital camera, removable devices and device actions (the last two are in kde:plasma-desktop) as plasma-desktop will ship with 5.8 in autumn I would say let it in master and the camera kcm will ship with 16.12 in the new subgroup. so it is as it is now and with 16.12 the kcm will move.</p></pre>
<br />
<p>- Andreas</p>
<br />
<p>On Juli 17th, 2016, 9:25 nachm. UTC, Andreas Kainz wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma and Thomas Pfeiffer.</div>
<div>By Andreas Kainz.</div>
<p style="color: grey;"><i>Updated Juli 17, 2016, 9:25 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kamera
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">with this patch https://git.reviewboard.kde.org/r/128445/ I add an subgroup removabel devices and now I move the kcm digital camera into the new subgroup.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcontrol/kamera.desktop <span style="color: grey">(0b35db8)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128447/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>