Review Request 128409: IconItem: Use better approach to disable animation when going from invisible to visible

[David Rosca]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128409/
-----------------------------------------------------------

(Updated July 12, 2016, 8:06 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit 9070f461bba483350c91528336a73ce68e41bde3 by David Rosca to branch master.


Repository: plasma-framework


Description
-------

Clearing the pixmap is actually wrong, because in some cases the IconItem::updatePolish() is not called when changing visibility.


Diffs
-----

  src/declarativeimports/core/iconitem.h e73829b 
  src/declarativeimports/core/iconitem.cpp 4f41b3b 

Diff: https://git.reviewboard.kde.org/r/128409/diff/


Testing
-------

Tests still pass.

The bug (no icon rendered) can be sometimes experienced in task manager volume controls and systray popup pin button. This patch fixes it.


Thanks,

David Rosca

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160712/98e542c8/attachment-0001.html>