Review Request 128409: IconItem: Use better approach to disable animation when going from invisible to visible
Anthony Fieroni
bvbfan at abv.bg
Mon Jul 11 08:40:12 UTC 2016
> On Юли 11, 2016, 11:10 преди обяд, Anthony Fieroni wrote:
> > src/declarativeimports/core/iconitem.cpp, line 483
> > <https://git.reviewboard.kde.org/r/128409/diff/1/?file=471439#file471439line483>
> >
> > Or here to be
> > m_oldIconPixmap = QPixmap();
> > ?
>
> David Rosca wrote:
> No, loadPixmap() does m_oldIconPixmap = m_iconPixmap, so this change would have no effect.
m_iconPixmap stays valid i.e. not be invisible, no?
- Anthony
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128409/#review97282
-----------------------------------------------------------
On Юли 9, 2016, 6:28 след обяд, David Rosca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128409/
> -----------------------------------------------------------
>
> (Updated Юли 9, 2016, 6:28 след обяд)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> Clearing the pixmap is actually wrong, because in some cases the IconItem::updatePolish() is not called when changing visibility.
>
>
> Diffs
> -----
>
> src/declarativeimports/core/iconitem.h e73829b
> src/declarativeimports/core/iconitem.cpp 4f41b3b
>
> Diff: https://git.reviewboard.kde.org/r/128409/diff/
>
>
> Testing
> -------
>
> Tests still pass.
>
> The bug (no icon rendered) can be sometimes experienced in task manager volume controls and systray popup pin button. This patch fixes it.
>
>
> Thanks,
>
> David Rosca
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160711/95d14033/attachment.html>
More information about the Plasma-devel
mailing list