Review Request 128409: IconItem: Use better approach to disable animation when going from invisible to visible

[David Rosca]

> On July 11, 2016, 8:10 a.m., Anthony Fieroni wrote:
> > src/declarativeimports/core/iconitem.cpp, line 483
> > <https://git.reviewboard.kde.org/r/128409/diff/1/?file=471439#file471439line483>
> >
> >     Or here to be
> >     m_oldIconPixmap = QPixmap();
> >     ?

No, loadPixmap() does m_oldIconPixmap = m_iconPixmap, so this change would have no effect.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128409/#review97282
-----------------------------------------------------------


On July 9, 2016, 3:28 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128409/
> -----------------------------------------------------------
> 
> (Updated July 9, 2016, 3:28 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Clearing the pixmap is actually wrong, because in some cases the IconItem::updatePolish() is not called when changing visibility.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/iconitem.h e73829b 
>   src/declarativeimports/core/iconitem.cpp 4f41b3b 
> 
> Diff: https://git.reviewboard.kde.org/r/128409/diff/
> 
> 
> Testing
> -------
> 
> Tests still pass.
> 
> The bug (no icon rendered) can be sometimes experienced in task manager volume controls and systray popup pin button. This patch fixes it.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160711/af285493/attachment-0001.html>