[Differential] [Request, 5 lines] D2092: Fix icon loading in Widget Explorer

[davidedmundson (David Edmundson)]

davidedmundson created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  In new Qt (not sure which version) QIcon::fromTheme(QString) returns a
  valid icon object, thus hasThemeIcon always returns true as that simply
  calls fromTheme internally and checks the names match.
  
  This patch uses the same check as the new QIcon::fromTheme(QString
  &name, QIcon fallback) to check the original icon was found.
  
  This patch is therefore not only is a workaround but also a speed bost
  as before we were effectively loading the same icon twice.
  
  BUG: 365111

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  Plasma/5.7

REVISION DETAIL
  https://phabricator.kde.org/D2092

AFFECTED FILES
  components/shellprivate/widgetexplorer/plasmaappletitemmodel.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson
Cc: plasma-devel, jensreuterberg, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160705/3a030fa6/attachment.html>