Review Request 126893: [kioslave/remote] fix knetattach .desktop filename

Takahiro Hashimoto kenya888 at gmail.com
Fri Jan 29 08:11:23 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126893/
-----------------------------------------------------------

(Updated Jan. 29, 2016, 5:11 p.m.)


Review request for Plasma.


Changes
-------

file the bug on the bugzilla.


Bugs: 358723
    https://bugs.kde.org/show_bug.cgi?id=358723


Repository: plasma-workspace


Description
-------

The knetattach .desktop file has been renamed to 'org.kde.knetattach.desktop'.
The wizard service name should be changed to the same string.

This patch simply fixes service name of knetatach.


Diffs
-----

  kioslave/remote/remoteimpl.cpp ad04a7b 

Diff: https://git.reviewboard.kde.org/r/126893/diff/


Testing
-------

Confirmed the "Add Network Folder" icon rework in dolphin.
kioslave/remote/tests/testremote has been passed.

We may have some issues about knetattach. At present I cannot create sftp network folder. I have confirmed that the ftp network folder works correctly.


Thanks,

Takahiro Hashimoto

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160129/113577a5/attachment.html>


More information about the Plasma-devel mailing list