Review Request 126893: [kioslave/remote] fix knetattach .desktop filename

Takahiro Hashimoto kenya888 at gmail.com
Tue Jan 26 13:52:55 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126893/
-----------------------------------------------------------

(Updated 1月 26, 2016, 10:52 p.m.)


Review request for Plasma.


Changes
-------

add comment.


Repository: plasma-workspace


Description
-------

The knetattach .desktop file has been renamed to 'org.kde.knetattach.desktop'.
The wizard service name should be changed to the same string.

This patch simply fixes service name of knetatach.


Diffs
-----

  kioslave/remote/remoteimpl.cpp ad04a7b 

Diff: https://git.reviewboard.kde.org/r/126893/diff/


Testing (updated)
-------

Confirmed the "Add Network Folder" icon rework in dolphin.
kioslave/remote/tests/testremote has been passed.

We may have some issues about knetattach. At present I cannot create sftp network folder. I have confirmed that the ftp network folder works correctly.


Thanks,

Takahiro Hashimoto

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160126/32e0d815/attachment.html>


More information about the Plasma-devel mailing list