Review Request 126300: Plasma Search KCM: display the runner descriptions

Jonathan Marten jjm at keelhaul.me.uk
Wed Jan 27 06:56:27 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126300/
-----------------------------------------------------------

(Updated Jan. 27, 2016, 6:56 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma and KDE Usability.


Changes
-------

Submitted with commit 3546406db06600ff61132085e08366d62cbab53f by Jonathan Marten to branch master.


Repository: plasma-desktop


Description
-------

In Plasma 5 this KCM only lists the names of the available runners, with no explanation of what they do.  In its previous incarnation in KDE4 (the dropdown list from the runner config button), the descriptions were displayed.  This change restores them.


Diffs
-----

  kcms/runners/kcm.h f1239ee 
  kcms/runners/kcm.cpp 4af82de 

Diff: https://git.reviewboard.kde.org/r/126300/diff/


Testing
-------

Built plasma-desktop with this change, checked appearance of KCM in Breeze, Oxygen and older styles.


File Attachments
----------------

Screenshot before
  https://git.reviewboard.kde.org/media/uploaded/files/2015/12/10/caf0a4d7-ab8d-410a-9409-ae6935d24929__plasmasearch-before-r126300.png
Screenshot after
  https://git.reviewboard.kde.org/media/uploaded/files/2015/12/10/0b695a2b-4307-4a70-9a9b-4c3bb80f7955__plasmasearch-after-r126300.png
Long lines elided
  https://git.reviewboard.kde.org/media/uploaded/files/2016/01/10/193898fa-d860-4263-b2c1-e060a89522dc__plasmasearch-elided-r126303.png


Thanks,

Jonathan Marten

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160127/e93b6b8b/attachment.html>


More information about the Plasma-devel mailing list