Review Request 126825: Don't set available space when rotating applet

David Rosca nowrep at gmail.com
Wed Jan 20 15:32:19 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126825/
-----------------------------------------------------------

(Updated Jan. 20, 2016, 3:32 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit 785cb63428cfe93f1456d03332581ffcda5eed10 by David Rosca to branch master.


Repository: plasma-desktop


Description
-------

The space is freed in onPressed, but not taken back in onReleased.
LayoutManager currently ignores applet rotation when calculating free space, so there is no need to update it at all when rotating the applet.


Diffs
-----

  containments/desktop/package/contents/ui/AppletHandle.qml 1a74900 

Diff: https://git.reviewboard.kde.org/r/126825/diff/


Testing
-------

Rotating the applet no longer makes the whole applet area free in LayoutManager.


Thanks,

David Rosca

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160120/87346589/attachment.html>


More information about the Plasma-devel mailing list