Review Request 126825: Don't set available space when rotating applet

David Edmundson david at davidedmundson.co.uk
Wed Jan 20 15:30:16 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126825/#review91381
-----------------------------------------------------------


Ship it!




Ship It!

- David Edmundson


On Jan. 20, 2016, 3:12 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126825/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2016, 3:12 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> The space is freed in onPressed, but not taken back in onReleased.
> LayoutManager currently ignores applet rotation when calculating free space, so there is no need to update it at all when rotating the applet.
> 
> 
> Diffs
> -----
> 
>   containments/desktop/package/contents/ui/AppletHandle.qml 1a74900 
> 
> Diff: https://git.reviewboard.kde.org/r/126825/diff/
> 
> 
> Testing
> -------
> 
> Rotating the applet no longer makes the whole applet area free in LayoutManager.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160120/d8e3001f/attachment-0001.html>


More information about the Plasma-devel mailing list