Review Request 126802: AppletConfig: Fix binding loop on width in categories scrollview
David Rosca
nowrep at gmail.com
Tue Jan 19 17:02:20 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126802/
-----------------------------------------------------------
(Updated Jan. 19, 2016, 5:02 p.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma.
Changes
-------
Submitted with commit e22a6d5f6ea420218fe0e099fcd11631d70319e6 by David Rosca to branch master.
Repository: plasma-desktop
Description
-------
Fixes issue where the contents rectangle may be smaller than the ScrollView's width.
Diffs
-----
desktoppackage/contents/configuration/AppletConfiguration.qml 0302c7a
Diff: https://git.reviewboard.kde.org/r/126802/diff/
Testing
-------
Issue fixed (the issue doesn't occur for every config dialog).
To be honest, it fixes binding loop on `width` in our code, but also brings binding loop on `value` in Qt ScrollView.qml. But it still fixes the issue.
File Attachments
----------------
before.png
https://git.reviewboard.kde.org/media/uploaded/files/2016/01/18/4d06a54a-ac6c-45dc-8c32-53415e8b35d5__before.png
Thanks,
David Rosca
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160119/757165f7/attachment.html>
More information about the Plasma-devel
mailing list