Review Request 126802: AppletConfig: Fix binding loop on width in categories scrollview
David Edmundson
david at davidedmundson.co.uk
Tue Jan 19 16:32:28 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126802/#review91339
-----------------------------------------------------------
Ship it!
Ship It!
- David Edmundson
On Jan. 19, 2016, 4:12 p.m., David Rosca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126802/
> -----------------------------------------------------------
>
> (Updated Jan. 19, 2016, 4:12 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> Fixes issue where the contents rectangle may be smaller than the ScrollView's width.
>
>
> Diffs
> -----
>
> desktoppackage/contents/configuration/AppletConfiguration.qml 0302c7a
>
> Diff: https://git.reviewboard.kde.org/r/126802/diff/
>
>
> Testing
> -------
>
> Issue fixed (the issue doesn't occur for every config dialog).
> To be honest, it fixes binding loop on `width` in our code, but also brings binding loop on `value` in Qt ScrollView.qml. But it still fixes the issue.
>
>
> File Attachments
> ----------------
>
> before.png
> https://git.reviewboard.kde.org/media/uploaded/files/2016/01/18/4d06a54a-ac6c-45dc-8c32-53415e8b35d5__before.png
>
>
> Thanks,
>
> David Rosca
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160119/3e10b449/attachment-0001.html>
More information about the Plasma-devel
mailing list