Review Request 126652: [Units] Return at least 1ms for durations

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126652/
-----------------------------------------------------------

(Updated Jan. 17, 2016, noon)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit d9719f10374f4885a3ae3efd7e3b4f23e953e59d by Kai Uwe Broulik to branch master.


Bugs: 357352
    http://bugs.kde.org/show_bug.cgi?id=357352


Repository: plasma-framework


Description
-------

Animators do not reliably fire with a duration of 0 as can be seen in the linked bug report.

Upstream bug report: https://bugreports.qt.io/browse/QTBUG-39766


Diffs
-----

  src/declarativeimports/core/units.cpp 1798727 
  src/declarativeimports/plasmacomponents/qml/PageStack.qml cdb2a49 

Diff: https://git.reviewboard.kde.org/r/126652/diff/


Testing
-------

This fixes Widget Explorer and System Tray for me.

Yet another reason not to divide long/shortDuration by arbitrary values. :)

Also I don't know if there are things that check for an animation duration to disable certain behaviors.


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160117/97d15c40/attachment-0001.html>