Review Request 126652: [Units] Return at least 1ms for durations

[David Edmundson]

> On Jan. 7, 2016, 4:32 p.m., Kai Uwe Broulik wrote:
> > I guess we should rather get https://codereview.qt-project.org/#/c/145237/ in :)

nah, that'll be Qt 5.6 at the earliest.

+1 from me on the patch.
It's fine to have workarounds if we know they'll only be temporary workarounds.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126652/#review90769
-----------------------------------------------------------


On Jan. 6, 2016, 12:42 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126652/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2016, 12:42 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 357352
>     http://bugs.kde.org/show_bug.cgi?id=357352
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Animators do not reliably fire with a duration of 0 as can be seen in the linked bug report.
> 
> Upstream bug report: https://bugreports.qt.io/browse/QTBUG-39766
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/plasmacomponents/qml/PageStack.qml cdb2a49 
>   src/declarativeimports/core/units.cpp 1798727 
> 
> Diff: https://git.reviewboard.kde.org/r/126652/diff/
> 
> 
> Testing
> -------
> 
> This fixes Widget Explorer and System Tray for me.
> 
> Yet another reason not to divide long/shortDuration by arbitrary values. :)
> 
> Also I don't know if there are things that check for an animation duration to disable certain behaviors.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160107/673c255d/attachment.html>