Review Request 126752: Auto-add Input Method Panel widget to Default Panel when run with relevant language

[Eike Hein]

> On Jan. 15, 2016, 7:24 a.m., Martin Gräßlin wrote:
> > layout-templates/org.kde.plasma.desktop.defaultPanel/contents/layout.js, line 45
> > <https://git.reviewboard.kde.org/r/126752/diff/1/?file=430779#file430779line45>
> >
> >     could we feed them in from a config file? So that also the user can easily add additional ones (does that make sense at all?)

I agree, however this is meant as an incremental improvement of sorts. The longer-term plan is to introduce a proper notion of input language support in Plasma and merge kimpanel and the keyboard layout indicator. At that point the entire package (widget presence, setting up the language in the IME backend, and getting the keyboard layout right) needs to be set up at first login, and I don't want to introduce any API treading on that turf just yet, as how that state is transferred from distro install into our session is still not clear. It's better to keep this decision internal for now.


- Eike


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126752/#review91125
-----------------------------------------------------------


On Jan. 15, 2016, 2:14 a.m., Eike Hein wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126752/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2016, 2:14 a.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Since the Input Method Panel (kimpanel) widget was recently moved to plasma-desktop and is now guaranteed to be around, this patch will auto-add it to the Default Panel when the shell is run in a relevant locale. The white list of locale language id's is based on the list Fedora 23 uses to determine whether or not to require installation of the ibus IME stack (one of kimpanel's supported backends) at installation time.
> 
> This requires https://git.reviewboard.kde.org/r/126751/ to work.
> 
> 
> Diffs
> -----
> 
>   layout-templates/org.kde.plasma.desktop.defaultPanel/contents/layout.js 5ff228b 
> 
> Diff: https://git.reviewboard.kde.org/r/126752/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Eike Hein
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160115/2ca42bed/attachment.html>