Review Request 126752: Auto-add Input Method Panel widget to Default Panel when run with relevant language

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126752/#review91132
-----------------------------------------------------------


Ship it!




having the list of languages hardcoded there seems indeed a bit hmm, hardcoded.
however I think it's just fine to have it quickly and may well end up being enough

- Marco Martin


On Jan. 15, 2016, 2:14 a.m., Eike Hein wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126752/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2016, 2:14 a.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Since the Input Method Panel (kimpanel) widget was recently moved to plasma-desktop and is now guaranteed to be around, this patch will auto-add it to the Default Panel when the shell is run in a relevant locale. The white list of locale language id's is based on the list Fedora 23 uses to determine whether or not to require installation of the ibus IME stack (one of kimpanel's supported backends) at installation time.
> 
> This requires https://git.reviewboard.kde.org/r/126751/ to work.
> 
> 
> Diffs
> -----
> 
>   layout-templates/org.kde.plasma.desktop.defaultPanel/contents/layout.js 5ff228b 
> 
> Diff: https://git.reviewboard.kde.org/r/126752/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Eike Hein
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160115/0c822583/attachment.html>