Review Request 126731: Fix calculation of availableSpace for applets

David Rosca nowrep at gmail.com
Wed Jan 13 15:13:45 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126731/
-----------------------------------------------------------

(Updated Jan. 13, 2016, 3:13 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit 2c56715c93cb439df77f29260e3bfc9cbd76e806 by David Rosca to branch master.


Bugs: 346815
    https://bugs.kde.org/show_bug.cgi?id=346815


Repository: plasma-desktop


Description
-------

Fix calculation when positions[row] is undefined. Currently it would incorrectly return the whole requested area being available without any further checks.


Diffs
-----

  containments/desktop/package/contents/code/LayoutManager.js fbb879e 
  containments/desktop/package/contents/ui/main.qml fc52250 

Diff: https://git.reviewboard.kde.org/r/126731/diff/


Testing
-------

No longer possible to place applets on top of each others.


Thanks,

David Rosca

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160113/86aa4980/attachment.html>


More information about the Plasma-devel mailing list