Review Request 126731: Fix calculation of availableSpace for applets
Eike Hein
hein at kde.org
Wed Jan 13 14:54:24 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126731/#review91011
-----------------------------------------------------------
Ship it!
Ship It!
- Eike Hein
On Jan. 13, 2016, 2:36 p.m., David Rosca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126731/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2016, 2:36 p.m.)
>
>
> Review request for Plasma.
>
>
> Bugs: 346815
> https://bugs.kde.org/show_bug.cgi?id=346815
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> Fix calculation when positions[row] is undefined. Currently it would incorrectly return the whole requested area being available without any further checks.
>
>
> Diffs
> -----
>
> containments/desktop/package/contents/code/LayoutManager.js fbb879e
> containments/desktop/package/contents/ui/main.qml fc52250
>
> Diff: https://git.reviewboard.kde.org/r/126731/diff/
>
>
> Testing
> -------
>
> No longer possible to place applets on top of each others.
>
>
> Thanks,
>
> David Rosca
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160113/5b8a3ed9/attachment.html>
More information about the Plasma-devel
mailing list