Review Request 126300: Plasma Search KCM: display the runner descriptions

[Jonathan Marten]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126300/
-----------------------------------------------------------

(Updated Jan. 10, 2016, 4:33 p.m.)


Review request for Plasma and KDE Usability.


Changes
-------

Long description lines elided with "..." instead of simply truncated, screenshot updated.

Not sure if it's possible to show a tool tip only if the description is truncated, since the width calculation is done while painting in the item delegate but the tool tip would have to be set when the items are statically created in SearchConfigModule::load().  So the options would be to have either no tool tip, or a tool tip for everything even if the text is not truncated.  Since the "Control Audio Player" example seems to be the only one that gets truncated in a standard Plasma5 install with the standard dialogue and font sizes, I'm not sure it is worth addressing.


Repository: plasma-desktop


Description
-------

In Plasma 5 this KCM only lists the names of the available runners, with no explanation of what they do.  In its previous incarnation in KDE4 (the dropdown list from the runner config button), the descriptions were displayed.  This change restores them.


Diffs (updated)
-----

  kcms/runners/kcm.h f1239ee 
  kcms/runners/kcm.cpp 4af82de 

Diff: https://git.reviewboard.kde.org/r/126300/diff/


Testing
-------

Built plasma-desktop with this change, checked appearance of KCM in Breeze, Oxygen and older styles.


File Attachments (updated)
----------------

Screenshot before
  https://git.reviewboard.kde.org/media/uploaded/files/2015/12/10/caf0a4d7-ab8d-410a-9409-ae6935d24929__plasmasearch-before-r126300.png
Screenshot after
  https://git.reviewboard.kde.org/media/uploaded/files/2015/12/10/0b695a2b-4307-4a70-9a9b-4c3bb80f7955__plasmasearch-after-r126300.png
Long lines elided
  https://git.reviewboard.kde.org/media/uploaded/files/2016/01/10/193898fa-d860-4263-b2c1-e060a89522dc__plasmasearch-elided-r126303.png


Thanks,

Jonathan Marten

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160110/a1b90e8e/attachment.html>