Review Request 126300: Plasma Search KCM: display the runner descriptions

[Jonathan Marten]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126300/
-----------------------------------------------------------

(Updated Jan. 7, 2016, 1:50 p.m.)


Review request for Plasma and KDE Usability.


Changes
-------

Diff updated in accordance with review comments.


Repository: plasma-desktop


Description
-------

In Plasma 5 this KCM only lists the names of the available runners, with no explanation of what they do.  In its previous incarnation in KDE4 (the dropdown list from the runner config button), the descriptions were displayed.  This change restores them.


Diffs (updated)
-----

  kcms/runners/kcm.h f1239ee 
  kcms/runners/kcm.cpp 4af82de 

Diff: https://git.reviewboard.kde.org/r/126300/diff/


Testing
-------

Built plasma-desktop with this change, checked appearance of KCM in Breeze, Oxygen and older styles.


File Attachments (updated)
----------------

Screenshot before
  https://git.reviewboard.kde.org/media/uploaded/files/2015/12/10/caf0a4d7-ab8d-410a-9409-ae6935d24929__plasmasearch-before-r126300.png
Screenshot after
  https://git.reviewboard.kde.org/media/uploaded/files/2015/12/10/0b695a2b-4307-4a70-9a9b-4c3bb80f7955__plasmasearch-after-r126300.png
Long lines truncated
  https://git.reviewboard.kde.org/media/uploaded/files/2016/01/07/f91d5bc6-eb02-49e1-b99a-337ee6823fec__plasmasearch-longlines-r126300.png


Thanks,

Jonathan Marten

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160107/dd4f059d/attachment.html>