Review Request 126673: [Device Notifer] Rewrite delegates to use Layouts

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126673/#review90797
-----------------------------------------------------------

Ship it!


Ship It!

- Marco Martin


On Jan. 7, 2016, 11:30 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126673/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2016, 11:30 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> The code is from 2011/2012 before we had smart layouts and thus is pretty complicated with a lot of anchoring, this cleans up the code massively.
> 
> The layout layout is a bit tighter now, the eject/mount button is now a proper ToolButton. The "n actions for this device" text disappears when the actions are expanded, as you can now see the actions. Appearance/disappearance of the disk usage bar is now nicely animated, the lagging behind hover effect has been removed, however.
> 
> Also VDG: I need an action icon for "mount" (and possible for "unmount" as well)
> 
> 
> Diffs
> -----
> 
>   applets/devicenotifier/package/contents/ui/ActionItem.qml e5ec90d 
>   applets/devicenotifier/package/contents/ui/DeviceItem.qml 1a07c3f 
>   applets/devicenotifier/package/contents/ui/FullRepresentation.qml 48546f1 
> 
> Diff: https://git.reviewboard.kde.org/r/126673/diff/
> 
> 
> Testing
> -------
> 
> I have the feeling the busy indicator doesn't show anymore and that the "expand newly inserted device automatically" also no longer works.
> 
> Also, IconItem doesn't like when its opacity isn't 1 (Bug 355894) and I get strange glowing when the actions list expands.
> 
> Next step will be improving the status bar by providing in-line feedback (ie. you click unmount on your USB stick and your USB stick gets a warning icon with a message, instead of this detached status bar at the bottom)
> 
> 
> File Attachments
> ----------------
> 
> Before
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/01/07/7e128987-b7c5-4f89-a418-b9c520e9ed47__devicenotifierreviewold.png
> After
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/01/07/2df5974a-bc4d-4819-9860-4fe82eb8d0c8__devicenotifierreviewnew1.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160108/68fcfb28/attachment.html>