<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126673/">https://git.reviewboard.kde.org/r/126673/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
<br />
<p>- Marco Martin</p>
<br />
<p>On January 7th, 2016, 11:30 p.m. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma and KDE Usability.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Jan. 7, 2016, 11:30 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The code is from 2011/2012 before we had smart layouts and thus is pretty complicated with a lot of anchoring, this cleans up the code massively.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The layout layout is a bit tighter now, the eject/mount button is now a proper ToolButton. The "n actions for this device" text disappears when the actions are expanded, as you can now see the actions. Appearance/disappearance of the disk usage bar is now nicely animated, the lagging behind hover effect has been removed, however.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also VDG: I need an action icon for "mount" (and possible for "unmount" as well)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I have the feeling the busy indicator doesn't show anymore and that the "expand newly inserted device automatically" also no longer works.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also, IconItem doesn't like when its opacity isn't 1 (Bug 355894) and I get strange glowing when the actions list expands.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Next step will be improving the status bar by providing in-line feedback (ie. you click unmount on your USB stick and your USB stick gets a warning icon with a message, instead of this detached status bar at the bottom)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/devicenotifier/package/contents/ui/ActionItem.qml <span style="color: grey">(e5ec90d)</span></li>
<li>applets/devicenotifier/package/contents/ui/DeviceItem.qml <span style="color: grey">(1a07c3f)</span></li>
<li>applets/devicenotifier/package/contents/ui/FullRepresentation.qml <span style="color: grey">(48546f1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126673/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/01/07/7e128987-b7c5-4f89-a418-b9c520e9ed47__devicenotifierreviewold.png">Before</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/01/07/2df5974a-bc4d-4819-9860-4fe82eb8d0c8__devicenotifierreviewnew1.png">After</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>