Review Request 126647: [Task Manager] Provide media controls in tooltips
Kai Uwe Broulik
kde at privat.broulik.de
Tue Jan 5 20:45:55 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126647/
-----------------------------------------------------------
Review request for Plasma, KDE Usability and Eike Hein.
Bugs: 352126
https://bugs.kde.org/show_bug.cgi?id=352126
Repository: plasma-desktop
Description
-------
This adds media player controls to the tooltip of a media player, using the already existing mpris dataengine this was pretty straightforward to implement.
In order not to change the tooltip dialog size, the controls are placed ontop of the thumbnail with a little fade effect at the bottom to improve contrast.
There could be multiple grouped windows of a given player, unlikely though, but it doesn't look too bad with that either.
The app in the screenshot is just for demo purposes, the buttons are disabled in the screenshot, they're a darker black usually.
The button reflects play/pause state, forward/back are disabled if not possible and the controls, obviously, are only shown for tasks with an associated mpris interface.
Diffs
-----
applets/taskmanager/package/contents/ui/Task.qml 2a88886
applets/taskmanager/package/contents/ui/ToolTipDelegate.qml 972dd62
Diff: https://git.reviewboard.kde.org/r/126647/diff/
Testing
-------
Works with VLC and Audacious, does not work with Dragon as the player announces itself as "dragonplayer" while its Desktop file says "dragon"
File Attachments
----------------
Tooltip with media controls
https://git.reviewboard.kde.org/media/uploaded/files/2016/01/05/79c94b3c-5d64-4eb2-8cc6-1541abf28e5f__mpristaskfade.png
Thanks,
Kai Uwe Broulik
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160105/5530b434/attachment.html>
More information about the Plasma-devel
mailing list