Review Request 126634: SystemTray: Fix height of lines in table in Entries config

David Rosca nowrep at gmail.com
Tue Jan 5 12:34:15 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126634/
-----------------------------------------------------------

(Updated Jan. 5, 2016, 12:34 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit 5219f7977e7b0391972c536aa71992f795205228 by David Rosca to branch master.


Repository: plasma-workspace


Description
-------

Setting text to button makes its height return useful value.


Diffs
-----

  applets/systemtray/package/contents/ui/ConfigEntries.qml 7a59702 

Diff: https://git.reviewboard.kde.org/r/126634/diff/


Testing
-------

Looks fine now with Qt 5.6. Not sure if the issue is also in Plasma/5.5 (works fine for me with Qt 5.5)


File Attachments
----------------

before.png
  https://git.reviewboard.kde.org/media/uploaded/files/2016/01/05/1ed0a142-bc33-4cee-b912-c5f8423c6eb8__before.png
after.png
  https://git.reviewboard.kde.org/media/uploaded/files/2016/01/05/ea5b0e08-1d61-4299-ae03-03601341bbcc__after.png


Thanks,

David Rosca

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160105/cc3f8b17/attachment-0001.html>


More information about the Plasma-devel mailing list