Review Request 126634: SystemTray: Fix height of lines in table in Entries config

Sebastian Kügler sebas at kde.org
Tue Jan 5 12:31:33 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126634/#review90641
-----------------------------------------------------------

Ship it!


Ship It!

- Sebastian Kügler


On Jan. 5, 2016, 12:27 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126634/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2016, 12:27 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Setting text to button makes its height return useful value.
> 
> 
> Diffs
> -----
> 
>   applets/systemtray/package/contents/ui/ConfigEntries.qml 7a59702 
> 
> Diff: https://git.reviewboard.kde.org/r/126634/diff/
> 
> 
> Testing
> -------
> 
> Looks fine now with Qt 5.6. Not sure if the issue is also in Plasma/5.5 (works fine for me with Qt 5.5)
> 
> 
> File Attachments
> ----------------
> 
> before.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/01/05/1ed0a142-bc33-4cee-b912-c5f8423c6eb8__before.png
> after.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/01/05/ea5b0e08-1d61-4299-ae03-03601341bbcc__after.png
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160105/c93bf54a/attachment.html>


More information about the Plasma-devel mailing list