[Differential] [Request, 83 lines] D1028: RFC: Remove custom RubberBand painter
broulik (Kai Uwe Broulik)
noreply at phabricator.kde.org
Sat Feb 27 12:12:23 UTC 2016
broulik created this revision.
broulik added reviewers: Plasma, hein.
broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop.
broulik added a project: Plasma.
Herald added a subscriber: plasma-devel.
This removes the custom RubberBand that is painted using QStyle and instead uses a traditional Rectangle.
We don't use "Desktop Widget Style" in Plasma anyway. The rubber band now follows the theme's highlight color and has a nice fade animation when it disappears.
Rubber band selection works fine.
Repeated quick moving and selecting doesn't make it go nuts, even when the fade out animation is still running.
Auto scroll in both popup and as containment is erratic; not sure if this is caused by this patch, however.
Using Tilain the rubber band is now white, for example, using Oxygen it's a fainter blue.
I did not yet remove the RubberBand cpp stuff as I wanted to get some feedback first before messing up my local repository :)
rPLASMADESKTOP Plasma Desktop
To: broulik, Plasma, hein
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Plasma-devel