Review Request 126930: sddm theme: Add keyboard layout button
David Rosca
nowrep at gmail.com
Wed Feb 24 13:15:10 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126930/
-----------------------------------------------------------
(Updated Feb. 24, 2016, 5:15 a.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma.
Changes
-------
Submitted with commit bea1a457316756ef732aa8315376a2cf82519281 by David Rosca to branch master.
Repository: plasma-workspace
Description
-------
Show keyboard layout button in sddm theme, same as in lock screen.
Diffs
-----
lookandfeel/contents/loginmanager/Main.qml 1bbefec
lookandfeel/contents/loginmanager/dummydata/keyboard.qml PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/126930/diff/
Testing
-------
Looks & works exactly the same as in lock screen.
Btw, there is a comment saying that password input must be first child to get focus (automatically when login screen is shown?), but it is not true. It works fine (in all cases = qmlscene, sddm-greeter --test-mode and in actual sddm session) even with password input being second child. So, remove the comment?
Thanks,
David Rosca
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160224/ab34dc58/attachment-0001.html>
More information about the Plasma-devel
mailing list