Review Request 126930: sddm theme: Add keyboard layout button

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126930/#review92659
-----------------------------------------------------------


Ship it!




Ship It!

- David Edmundson


On Feb. 21, 2016, 12:50 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126930/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2016, 12:50 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Show keyboard layout button in sddm theme, same as in lock screen.
> 
> 
> Diffs
> -----
> 
>   lookandfeel/contents/loginmanager/Main.qml 1bbefec 
>   lookandfeel/contents/loginmanager/dummydata/keyboard.qml PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126930/diff/
> 
> 
> Testing
> -------
> 
> Looks & works exactly the same as in lock screen.
> 
> Btw, there is a comment saying that password input must be first child to get focus (automatically when login screen is shown?), but it is not true. It works fine (in all cases = qmlscene, sddm-greeter --test-mode and in actual sddm session) even with password input being second child. So, remove the comment?
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160223/ba01a05a/attachment.html>