Review Request 127160: Don't force reload profile when battery status changed

Xuetian Weng wengxt at
Tue Feb 23 23:02:45 UTC 2016

This is an automatically generated e-mail. To reply, visit:

(Updated Feb. 24, 2016, 12:02 a.m.)


This change has been marked as submitted.

Review request for Plasma and Kai Uwe Broulik.


Submitted with commit f5449a05a6e7fda8a00ace21bc7401ed33712a80 by Weng Xuetian to branch master.

Repository: powerdevil


But I have a device that could discharging even when AC on when high load happens, and status of battery changes frequently under such case.

loadProfile(force=true) would make my AC profile being loaded again and again thus my adjusted brightness level is reset again and again, which is extremely annoying. Not sure if we really need to reparseConfiguration() and loadProfile(true) when battery status changed, isn't loadProfile() is good enough? onAcAdapterStateChanged() only uses loadProfile().


  daemon/powerdevilcore.cpp 3630541 



not sure if this can causes any regression, but profile is not reset to settings when battery status changed.


Xuetian Weng

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the Plasma-devel mailing list