Review Request 127160: Don't force reload profile when battery status changed

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127160/#review92680
-----------------------------------------------------------


Ship it!




Ship It!

- Kai Uwe Broulik


On Feb. 23, 2016, 10:14 nachm., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127160/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2016, 10:14 nachm.)
> 
> 
> Review request for Plasma and Kai Uwe Broulik.
> 
> 
> Repository: powerdevil
> 
> 
> Description
> -------
> 
> But I have a device that could discharging even when AC on when high load happens, and status of battery changes frequently under such case.
> 
> loadProfile(force=true) would make my AC profile being loaded again and again thus my adjusted brightness level is reset again and again, which is extremely annoying. Not sure if we really need to reparseConfiguration() and loadProfile(true) when battery status changed, isn't loadProfile() is good enough? onAcAdapterStateChanged() only uses loadProfile().
> 
> 
> Diffs
> -----
> 
>   daemon/powerdevilcore.cpp 3630541 
> 
> Diff: https://git.reviewboard.kde.org/r/127160/diff/
> 
> 
> Testing
> -------
> 
> not sure if this can causes any regression, but profile is not reset to settings when battery status changed.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160223/f3cc24a0/attachment-0001.html>