Review Request 127118: ToolTip: Prevent multiple geometry changes while changing contents

David Rosca nowrep at gmail.com
Sun Feb 21 14:17:39 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127118/
-----------------------------------------------------------

(Updated Feb. 21, 2016, 2:17 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit fca765bc05d4ad1ac90982ef7a99a1541c846e1f by David Rosca to branch master.


Repository: plasma-framework


Description
-------

Unset mainItem and set it back only after changing of tooltip contents is completed.
This improves behavior of morphingpopups effect (popups animates from/to incorrect values).


Diffs
-----

  src/declarativeimports/core/tooltip.cpp 3d2e7da 

Diff: https://git.reviewboard.kde.org/r/127118/diff/


Testing
-------

Tested with morphing popups effect, only one geometry change event is sent when tooltip slides to new position.


Thanks,

David Rosca

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160221/7774b171/attachment-0001.html>


More information about the Plasma-devel mailing list