Review Request 127118: ToolTip: Prevent multiple geometry changes while changing contents

David Edmundson david at davidedmundson.co.uk
Sun Feb 21 13:41:45 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127118/#review92607
-----------------------------------------------------------


Ship it!




Ship It!

- David Edmundson


On Feb. 21, 2016, 9:17 a.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127118/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2016, 9:17 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Unset mainItem and set it back only after changing of tooltip contents is completed.
> This improves behavior of morphingpopups effect (popups animates from/to incorrect values).
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/tooltip.cpp 3d2e7da 
> 
> Diff: https://git.reviewboard.kde.org/r/127118/diff/
> 
> 
> Testing
> -------
> 
> Tested with morphing popups effect, only one geometry change event is sent when tooltip slides to new position.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160221/6cb3a69c/attachment.html>


More information about the Plasma-devel mailing list