Review Request 127085: Make the desfault theme follow system colors

[Marco Martin]

> On Feb. 16, 2016, 5:05 p.m., Kai Uwe Broulik wrote:
> > File Attachment: color4.png - color4.png
> > <https://git.reviewboard.kde.org/r/127085/#fcomment509>
> >
> >     This is hard to read, perhaps the background contrast effect is still using light color?
> 
> Marco Martin wrote:
>     yeah, it's not adjusting backgroundcontrast, that may need fixing somehow
>     and that's *also* why is not exactly the same color
> 
> Jens Reuterberg wrote:
>     Note in general - as someone who dislike contrast at night - that is essentially the same visual effect I use on my computer making it on the one hand "hard to read" but on the other "calmer to read". Again, a user who prefers this will have to take their options into consideration
> 
> Andreas Kainz wrote:
>     i like the idea but I think it's to dangerous for set it by default. I would add it in the kcm to the advonced settings.
> 
> Jens Reuterberg wrote:
>     I disagree. Since the default is perfect the only effect it will have that will be negative is if the user plays around with colour themes too aggressively, in which case said user will be able to repair it easier.

i think i can calculate a sensible default for the kwin contrast effect tough (it would make the popup nearer to the color of the window)


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127085/#review92462
-----------------------------------------------------------


On Feb. 16, 2016, 12:28 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127085/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2016, 12:28 p.m.)
> 
> 
> Review request for Plasma and Jens Reuterberg.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> this makes the default plasma theme follow system colors, there are still "breeze light" and "breeze dark" themes that behave like the old two
> 
> 
> Diffs
> -----
> 
>   src/desktoptheme/CMakeLists.txt 3087c17 
>   src/desktoptheme/breeze-light/CMakeLists.txt PRE-CREATION 
>   src/desktoptheme/breeze-light/colors PRE-CREATION 
>   src/desktoptheme/breeze-light/metadata.desktop PRE-CREATION 
>   src/desktoptheme/breeze/CMakeLists.txt 2e28287 
>   src/desktoptheme/breeze/colors d701701 
> 
> Diff: https://git.reviewboard.kde.org/r/127085/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> color1.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/02/16/24f7dc82-1d66-4052-bc6f-af4aab0f15df__color1.png
> color2.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/02/16/93188d4f-242a-46ac-94a7-182ed600817b__color2.png
> color3.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/02/16/5151b63c-476b-4ff3-a653-42bf8168836f__color3.png
> color4.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/02/16/41febde6-795d-437c-b17e-ace92c84ea73__color4.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160216/119f5f9a/attachment.html>