<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127085/">https://git.reviewboard.kde.org/r/127085/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 16th, 2016, 5:05 p.m. UTC, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding: 0 0 0 1em;">
<br style="display: none;" />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/127085/file/2788/" style="color: black; font-weight: bold; font-size: 9pt;">color4.png</a>
<p>color4.png</p>
</td>
</tr>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is hard to read, perhaps the background contrast effect is still using light color?</pre>
</blockquote>
<p>On February 16th, 2016, 5:08 p.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding: 0 0 0 1em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">yeah, it's not adjusting backgroundcontrast, that may need fixing somehow
and that's <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">also</em> why is not exactly the same color</p></pre>
</blockquote>
<p>On February 16th, 2016, 5:27 p.m. UTC, <b>Jens Reuterberg</b> wrote:</p>
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding: 0 0 0 1em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Note in general - as someone who dislike contrast at night - that is essentially the same visual effect I use on my computer making it on the one hand "hard to read" but on the other "calmer to read". Again, a user who prefers this will have to take their options into consideration</p></pre>
</blockquote>
<p>On February 16th, 2016, 5:47 p.m. UTC, <b>Andreas Kainz</b> wrote:</p>
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding: 0 0 0 1em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">i like the idea but I think it's to dangerous for set it by default. I would add it in the kcm to the advonced settings.</p></pre>
</blockquote>
<p>On February 16th, 2016, 6:08 p.m. UTC, <b>Jens Reuterberg</b> wrote:</p>
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding: 0 0 0 1em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I disagree. Since the default is perfect the only effect it will have that will be negative is if the user plays around with colour themes too aggressively, in which case said user will be able to repair it easier.</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">i think i can calculate a sensible default for the kwin contrast effect tough (it would make the popup nearer to the color of the window)</p></pre>
<br />
<p>- Marco</p>
<br />
<p>On February 16th, 2016, 12:28 p.m. UTC, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma and Jens Reuterberg.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated Feb. 16, 2016, 12:28 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">this makes the default plasma theme follow system colors, there are still "breeze light" and "breeze dark" themes that behave like the old two</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/desktoptheme/CMakeLists.txt <span style="color: grey">(3087c17)</span></li>
<li>src/desktoptheme/breeze-light/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/desktoptheme/breeze-light/colors <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/desktoptheme/breeze-light/metadata.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/desktoptheme/breeze/CMakeLists.txt <span style="color: grey">(2e28287)</span></li>
<li>src/desktoptheme/breeze/colors <span style="color: grey">(d701701)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127085/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/02/16/24f7dc82-1d66-4052-bc6f-af4aab0f15df__color1.png">color1.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/02/16/93188d4f-242a-46ac-94a7-182ed600817b__color2.png">color2.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/02/16/5151b63c-476b-4ff3-a653-42bf8168836f__color3.png">color3.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/02/16/41febde6-795d-437c-b17e-ace92c84ea73__color4.png">color4.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>