Review Request 126996: Drop usage of Qt4Support

[Aleix Pol Gonzalez]

> On Feb. 6, 2016, 12:22 a.m., David Edmundson wrote:
> > imports/activitymanager/switcherbackend.cpp, line 125
> > <https://git.reviewboard.kde.org/r/126996/diff/1/?file=442834#file442834line125>
> >
> >     this isn't identical.
> >     
> >     old code would match alt+shift+tab, yours doesn't.
> >     
> >     (tbh yours might be more right, but I want to check it's deliberate)
> 
> Aleix Pol Gonzalez wrote:
>     I'm not sure, I'll add Ivan.

Dropping the issue since Ivan ack'ed it.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126996/#review92109
-----------------------------------------------------------


On Feb. 8, 2016, 3:03 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126996/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2016, 3:03 a.m.)
> 
> 
> Review request for Plasma and Ivan Čukić.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> On non-kdelibs4support depending modules.
> 
> 
> Diffs
> -----
> 
>   applets/kicker/plugin/runnermodel.h d447efc 
>   applets/kicker/plugin/runnermodel.cpp a3c193a 
>   applets/pager/plugin/model.h 9382247 
>   applets/pager/plugin/model.cpp 1b80baa 
>   applets/trash/plugin/dirmodel.h 9e7ad12 
>   applets/trash/plugin/dirmodel.cpp cc36e1a 
>   containments/desktop/plugins/folder/mimetypesmodel.h f3d701c 
>   containments/desktop/plugins/folder/mimetypesmodel.cpp 731414a 
>   containments/desktop/plugins/folder/placesmodel.h b7f9f70 
>   containments/desktop/plugins/folder/placesmodel.cpp 9ca3bec 
>   containments/desktop/plugins/folder/previewpluginsmodel.h d340eb5 
>   containments/desktop/plugins/folder/previewpluginsmodel.cpp 2b14551 
>   imports/activitymanager/switcherbackend.cpp 939575f 
>   kcms/desktoptheme/thememodel.cpp 8274b72 
>   kcms/keyboard/kcm_view_models.h 434bbe9 
>   kcms/keyboard/preview/keysymhelper.cpp 1479fb0 
>   kcms/keyboard/tests/keyboard_daemon_test.cpp 885f070 
>   kcms/phonon/audiosetup.cpp bd6fcb0 
>   kcms/phonon/testspeakerwidget.cpp 45572be 
>   kcms/solid_actions/ActionModel.cpp 36a55cf 
>   kcms/solid_actions/PredicateModel.cpp 7d3a9da 
>   kcms/solid_actions/SolidActions.cpp 9b607d9 
> 
> Diff: https://git.reviewboard.kde.org/r/126996/diff/
> 
> 
> Testing
> -------
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160211/cb0c4ea1/attachment-0001.html>