<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126996/">https://git.reviewboard.kde.org/r/126996/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 6th, 2016, 12:22 a.m. CET, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/126996/diff/1/?file=442834#file442834line125" style="color: black; font-weight: bold; text-decoration: underline;">imports/activitymanager/switcherbackend.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">125</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">Qt</span><span class="o">::</span><span class="n">SHIFT</span> <span class="o">&</span> <span class="n">prevAction</span> <span class="o">&&</span> <span class="n">Qt</span><span class="o">::</span><span class="n">Key_Tab</span> <span class="o">&</span> <span class="n">prevAction</span><span class="p">)</span> <span class="p">{</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">125</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="n">prevAction</span> <span class="o">==</span> <span class="n">QKeySequence</span><span class="p">(</span><span class="n">Qt</span><span class="o">::</span><span class="n">ShiftModifier</span> <span class="o">|</span> <span class="n">Qt</span><span class="o">::</span><span class="n">Key_Tab</span><span class="p">))</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">this isn't identical.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">old code would match alt+shift+tab, yours doesn't.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">(tbh yours might be more right, but I want to check it's deliberate)</p></pre>
</blockquote>
<p>On February 8th, 2016, 1:04 a.m. CET, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm not sure, I'll add Ivan.</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Dropping the issue since Ivan ack'ed it.</p></pre>
<br />
<p>- Aleix</p>
<br />
<p>On February 8th, 2016, 3:03 a.m. CET, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma and Ivan Čukić.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Feb. 8, 2016, 3:03 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">On non-kdelibs4support depending modules.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Builds, tests pass.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/kicker/plugin/runnermodel.h <span style="color: grey">(d447efc)</span></li>
<li>applets/kicker/plugin/runnermodel.cpp <span style="color: grey">(a3c193a)</span></li>
<li>applets/pager/plugin/model.h <span style="color: grey">(9382247)</span></li>
<li>applets/pager/plugin/model.cpp <span style="color: grey">(1b80baa)</span></li>
<li>applets/trash/plugin/dirmodel.h <span style="color: grey">(9e7ad12)</span></li>
<li>applets/trash/plugin/dirmodel.cpp <span style="color: grey">(cc36e1a)</span></li>
<li>containments/desktop/plugins/folder/mimetypesmodel.h <span style="color: grey">(f3d701c)</span></li>
<li>containments/desktop/plugins/folder/mimetypesmodel.cpp <span style="color: grey">(731414a)</span></li>
<li>containments/desktop/plugins/folder/placesmodel.h <span style="color: grey">(b7f9f70)</span></li>
<li>containments/desktop/plugins/folder/placesmodel.cpp <span style="color: grey">(9ca3bec)</span></li>
<li>containments/desktop/plugins/folder/previewpluginsmodel.h <span style="color: grey">(d340eb5)</span></li>
<li>containments/desktop/plugins/folder/previewpluginsmodel.cpp <span style="color: grey">(2b14551)</span></li>
<li>imports/activitymanager/switcherbackend.cpp <span style="color: grey">(939575f)</span></li>
<li>kcms/desktoptheme/thememodel.cpp <span style="color: grey">(8274b72)</span></li>
<li>kcms/keyboard/kcm_view_models.h <span style="color: grey">(434bbe9)</span></li>
<li>kcms/keyboard/preview/keysymhelper.cpp <span style="color: grey">(1479fb0)</span></li>
<li>kcms/keyboard/tests/keyboard_daemon_test.cpp <span style="color: grey">(885f070)</span></li>
<li>kcms/phonon/audiosetup.cpp <span style="color: grey">(bd6fcb0)</span></li>
<li>kcms/phonon/testspeakerwidget.cpp <span style="color: grey">(45572be)</span></li>
<li>kcms/solid_actions/ActionModel.cpp <span style="color: grey">(36a55cf)</span></li>
<li>kcms/solid_actions/PredicateModel.cpp <span style="color: grey">(7d3a9da)</span></li>
<li>kcms/solid_actions/SolidActions.cpp <span style="color: grey">(9b607d9)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126996/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>