Review Request 126793: KF5 (Picture) Frame plasmoid

[Lars Pontoppidan]

> On Jan. 18, 2016, noon, Kai Uwe Broulik wrote:
> > Nice to see this applet coming back!
> > 
> > I was wondering if there could be more code shared between this applet and our image wallpaper, perhaps even "just" allow the image wallpaper to function also as an applet.
> > 
> > You have a lot of empty lines with whitespace in your code. Please check your editor settings.
> 
> Marco Martin wrote:
>     let's have it back, then let's think about how to semplify it by loading wallpaper plugins?
> 
> Lars Pontoppidan wrote:
>     Cheers guys
>     
>     I was missing this applet - so I thought I'd give it a shot.
>     
>     It's my first contribution to KDE so I might have some questions down the road :)
>     
>     To start out with; I have no idea how to implement the mentioned wallpaper plugins - heh
> 
> Lars Pontoppidan wrote:
>     Please see the new diff. I'm having trouble using the StringList type as the plasmoidviewer keeps crashing on me.

I commented out the "countdown" visuals as it makes plasmashell and Xorg use more and more CPU after a few minutes (a bug somewhere?).


- Lars


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126793/#review91257
-----------------------------------------------------------


On Feb. 8, 2016, 11:34 a.m., Lars Pontoppidan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126793/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2016, 11:34 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> -------
> 
> KF5 version of the (Picture) Frame widget
> 
> 
> Diffs
> -----
> 
>   applets/CMakeLists.txt ed938f8 
>   applets/mediaframe/CMakeLists.txt PRE-CREATION 
>   applets/mediaframe/Messages.sh PRE-CREATION 
>   applets/mediaframe/package/contents/config/config.qml PRE-CREATION 
>   applets/mediaframe/package/contents/config/main.xml PRE-CREATION 
>   applets/mediaframe/package/contents/ui/ConfigGeneral.qml PRE-CREATION 
>   applets/mediaframe/package/contents/ui/ConfigPaths.qml PRE-CREATION 
>   applets/mediaframe/package/contents/ui/main.qml PRE-CREATION 
>   applets/mediaframe/package/metadata.desktop PRE-CREATION 
>   applets/mediaframe/plugin/mediaframe.h PRE-CREATION 
>   applets/mediaframe/plugin/mediaframe.cpp PRE-CREATION 
>   applets/mediaframe/plugin/mediaframeplugin.h PRE-CREATION 
>   applets/mediaframe/plugin/mediaframeplugin.cpp PRE-CREATION 
>   applets/mediaframe/plugin/qmldir PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126793/diff/
> 
> 
> Testing
> -------
> 
> kdeplasma-addons builds on Kubuntu 15.10.
> 
> 
> Thanks,
> 
> Lars Pontoppidan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20160208/0fbd49d8/attachment-0001.html>