<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126793/">https://git.reviewboard.kde.org/r/126793/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 18th, 2016, noon UTC, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Nice to see this applet coming back!</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I was wondering if there could be more code shared between this applet and our image wallpaper, perhaps even "just" allow the image wallpaper to function also as an applet.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">You have a lot of empty lines with whitespace in your code. Please check your editor settings.</p></pre>
</blockquote>
<p>On January 21st, 2016, 11:10 a.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">let's have it back, then let's think about how to semplify it by loading wallpaper plugins?</p></pre>
</blockquote>
<p>On January 21st, 2016, 11:34 a.m. UTC, <b>Lars Pontoppidan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Cheers guys</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I was missing this applet - so I thought I'd give it a shot.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It's my first contribution to KDE so I might have some questions down the road :)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">To start out with; I have no idea how to implement the mentioned wallpaper plugins - heh</p></pre>
</blockquote>
<p>On February 5th, 2016, 12:49 p.m. UTC, <b>Lars Pontoppidan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Please see the new diff. I'm having trouble using the StringList type as the plasmoidviewer keeps crashing on me.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I commented out the "countdown" visuals as it makes plasmashell and Xorg use more and more CPU after a few minutes (a bug somewhere?).</p></pre>
<br />
<p>- Lars</p>
<br />
<p>On February 8th, 2016, 11:34 a.m. UTC, Lars Pontoppidan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Lars Pontoppidan.</div>
<p style="color: grey;"><i>Updated Feb. 8, 2016, 11:34 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeplasma-addons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">KF5 version of the (Picture) Frame widget</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">kdeplasma-addons builds on Kubuntu 15.10.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/CMakeLists.txt <span style="color: grey">(ed938f8)</span></li>
<li>applets/mediaframe/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/mediaframe/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/mediaframe/package/contents/config/config.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/mediaframe/package/contents/config/main.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/mediaframe/package/contents/ui/ConfigGeneral.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/mediaframe/package/contents/ui/ConfigPaths.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/mediaframe/package/contents/ui/main.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/mediaframe/package/metadata.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/mediaframe/plugin/mediaframe.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/mediaframe/plugin/mediaframe.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/mediaframe/plugin/mediaframeplugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/mediaframe/plugin/mediaframeplugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/mediaframe/plugin/qmldir <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126793/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>